Skip to content

build: fix strict_deps for angular-cli test lib #29674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −5
Closed

build: fix strict_deps for angular-cli test lib #29674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/angular/cli/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,14 @@ ts_project(
"node_modules/**",
],
),
# TODO: Fix strict_deps failure
ignore_strict_deps = True,
deps = [
":angular-cli_rjs",
":node_modules/@angular-devkit/core",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we prefer to move from the ts_project dependency here to the npm package one?

Or should the clean up be to migrate to relative paths? If I understand/remember correctly, we want to use the npm package here so that we don't cross the npm package boundary with relative paths.

If there were imports from @angular/cli those should be relative import paths instead though.

Copy link
Member

@devversion devversion Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. It's just a leftover because apparently no runtime test broke (likely due to the transitive deps!!). My goal is to restrict/fix this and make it safe by leveraging Bazel visibility rules better

":node_modules/@angular-devkit/schematics",
"//:node_modules/@types/semver",
"//:node_modules/@types/yargs",
"//packages/angular_devkit/core:core_rjs",
"//packages/angular_devkit/schematics:schematics_rjs",
"//packages/angular_devkit/schematics/testing:testing_rjs",
"//:node_modules/semver",
"//:node_modules/yargs",
],
)

Expand Down
Loading