Skip to content

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented May 1, 2025

Set isn't a stable interface, it's a concrete type that changes over time (new spec versions may add methods, older ones may lack methods). There shouldn't be a huge downside to just declaring this class as "its own thing".

Follow-up to #30208 which breaks on google3 import because the Set types are subtly different because of different TS configs.

@jkrems jkrems added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels May 1, 2025
@jkrems jkrems force-pushed the jk-concrete-set branch from c796c2b to a217fed Compare May 1, 2025 17:08
@jkrems jkrems merged commit 7ee4458 into angular:main May 1, 2025
30 checks passed
@jkrems
Copy link
Contributor Author

jkrems commented May 1, 2025

The changes were merged into the following branches: main, 20.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2025
@jkrems jkrems deleted the jk-concrete-set branch August 20, 2025 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/core target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants