refactor(@angular/build): switch back to rollup for chunk optimizer #31358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollup currently appears to be more effective at optimizing total output chunk count. While this is investigated further, the experimental chunk optimizer will be switched back to using rollup.
clydin
added
the
action: review
alan-agius4
approved these changes
Oct 1, 2025
alan-agius4
added
action: merge
|
Possibly related: rolldown/rolldown#5726 Generally it would be interesting to see what the difference between rolldown & rollup was, ideally with tested code so we can have a look 👍 |
sapphi-red
reviewed
Oct 7, 2025
|
|
||
| const result = await bundle.generate({ | ||
| minify: { mangle: false, compress: false }, | ||
| advancedChunks: { minSize: 8192 }, |
There was a problem hiding this comment.
This option won't have effect unless group is specified. There should be a warning about it (rolldown/rolldown#5009).
A correct option would be like
advancedChunks: { groups: [{ name: 'chunks' }], minSize: 8192 }(you would probably want to add maxSize as well, otherwise a huge chunk will be generated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup currently appears to be more effective at optimizing total output chunk count. While this is investigated further, the experimental chunk optimizer will be switched back to using rollup.