Skip to content

refactor(@angular/build): switch back to rollup for chunk optimizer #31358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

refactor(@angular/build): switch back to rollup for chunk optimizer #31358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ ts_project(
":node_modules/picomatch",
":node_modules/piscina",
":node_modules/postcss",
":node_modules/rolldown",
":node_modules/rollup",
":node_modules/sass",
":node_modules/source-map-support",
":node_modules/tinyglobby",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"parse5-html-rewriting-stream": "8.0.0",
"picomatch": "4.0.3",
"piscina": "5.1.3",
"rolldown": "1.0.0-beta.38",
"rollup": "4.52.3",
"sass": "1.90.0",
"semver": "7.7.2",
"source-map-support": "0.5.21",
Expand Down
7 changes: 3 additions & 4 deletions packages/angular/build/src/builders/application/chunk-optimizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import type { Message, Metafile } from 'esbuild';
import assert from 'node:assert';
import { type OutputAsset, type OutputChunk, rolldown } from 'rolldown';
import { type OutputAsset, type OutputChunk, rollup } from 'rollup';
import {
BuildOutputFile,
BuildOutputFileType,
Expand Down Expand Up @@ -216,7 +216,7 @@ export async function optimizeChunks(
let bundle;
let optimizedOutput;
try {
bundle = await rolldown({
bundle = await rollup({
input: mainFile,
plugins: [
{
Expand Down Expand Up @@ -252,8 +252,7 @@ export async function optimizeChunks(
});

const result = await bundle.generate({
minify: { mangle: false, compress: false },
advancedChunks: { minSize: 8192 },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option won't have effect unless group is specified. There should be a warning about it (rolldown/rolldown#5009).
A correct option would be like

advancedChunks: { groups: [{ name: 'chunks' }], minSize: 8192 }

(you would probably want to add maxSize as well, otherwise a huge chunk will be generated)

compact: true,
sourcemap,
chunkFileNames: (chunkInfo) => `${chunkInfo.name.replace(/-[a-zA-Z0-9]{8}$/, '')}-[hash].js`,
});
Expand Down
Loading