-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): exclude .angular from coverage in vitest #31365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clydin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for the contribution.
Since the .angular directory should be covered with the introduction of the default Vitest coverage excludes, maybe reword the commit message around providing default excludes?
packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
Outdated
Show resolved
Hide resolved
1ecfa9d to
6f9c53a
Compare
|
@clydin I updated the PR, PTAL |
clydin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you rebase to fix the conflicts?
6f9c53a to
65628e8
Compare
|
@clydin Done, thanks for the review |
|
Looks like you might have missed a conflict in the rebase. |
Ensures vitest coverage uses default exclude patterns in addition to user defined ones. This provides a behavior similar to 3478aa3 but for vitest, as the default exclusions contain directories starting with a dot.
65628e8 to
a59bff8
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Similar to 3478aa3 but for vitest.
This avoids having to manually list
.angularand all config files inangular.jsonDoes this PR introduce a breaking change?
Other information