fix(@angular/build): exclude .angular from coverage in vitest #31365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
requested changes
Oct 2, 2025
packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
Outdated
Show resolved
Hide resolved
cexbrayat
force-pushed
the
fix/exclude-coverage-vitest
branch
from
1ecfa9d to
6f9c53a
Compare
|
@clydin I updated the PR, PTAL |
clydin
approved these changes
Oct 2, 2025
cexbrayat
force-pushed
the
fix/exclude-coverage-vitest
branch
from
6f9c53a to
65628e8
Compare
|
@clydin Done, thanks for the review |
|
Looks like you might have missed a conflict in the rebase. |
Ensures vitest coverage uses default exclude patterns in addition to user defined ones. This provides a behavior similar to 3478aa3 but for vitest, as the default exclusions contain directories starting with a dot.
cexbrayat
force-pushed
the
fix/exclude-coverage-vitest
branch
from
65628e8 to
a59bff8
Compare
clydin
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Similar to 3478aa3 but for vitest.
This avoids having to manually list
.angularand all config files inangular.jsonDoes this PR introduce a breaking change?
Other information