Skip to content

fix(@angular/build): exclude .angular from coverage in vitest #31365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix(@angular/build): exclude .angular from coverage in vitest #31365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class VitestExecutor implements TestExecutor {
reporters: reporters ?? ['default'],
outputFile,
watch,
coverage: generateCoverageOption(coverage, this.projectName),
coverage: await generateCoverageOption(coverage, this.projectName),
...debugOptions,
},
{
Expand All @@ -204,16 +204,24 @@ export class VitestExecutor implements TestExecutor {
}
}

function generateCoverageOption(
async function generateCoverageOption(
coverage: NormalizedUnitTestBuilderOptions['coverage'],
projectName: string,
): VitestCoverageOption {
): Promise<VitestCoverageOption> {
if (!coverage) {
return {
enabled: false,
};
}

let defaultExcludes: string[] = [];
if (coverage.exclude) {
try {
const vitestConfig = await loadEsmModule<typeof import('vitest/config')>('vitest/config');
defaultExcludes = vitestConfig.coverageConfigDefaults.exclude;
} catch {}
}

return {
enabled: true,
all: coverage.all,
Expand All @@ -223,7 +231,16 @@ function generateCoverageOption(
thresholds: coverage.thresholds,
watermarks: coverage.watermarks,
// Special handling for `exclude`/`reporters` due to an undefined value causing upstream failures
...(coverage.exclude ? { exclude: coverage.exclude } : {}),
...(coverage.exclude
? {
exclude: [
// Augment the default exclude https://vitest.dev/config/#coverage-exclude
// with the user defined exclusions
...coverage.exclude,
...defaultExcludes,
],
}
: {}),
...(coverage.reporters
? ({ reporter: coverage.reporters } satisfies VitestCoverageOption)
: {}),
Expand Down