fix(material/datepicker): adds comparison ids and aria-describedby spans #30040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Angular Components Datepicker calendar-body .ts and .html files to add id values for if there is a comparison start/end date and to provide values to their respective html values to provide an aria-describedby value to be announced for screenreaders when comparison dates are present. Fixes b/195600299
essjay05
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
Updates previous fix to remove '-' from the comparison date labels to allow proper id recognition for the aria-describedby. Fixes b/195600299
andrewseguin
approved these changes
Nov 19, 2024
andrewseguin
added
target: patch
Updates goldens for previous fix.
andrewseguin
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ans (#30040) * fix(material/datepicker): adds comparison ids and aria-describedby spans Updates Angular Components Datepicker calendar-body .ts and .html files to add id values for if there is a comparison start/end date and to provide values to their respective html values to provide an aria-describedby value to be announced for screenreaders when comparison dates are present. Fixes b/195600299 * refactor(material/datepicker): removes '-' for proper id recognition Updates previous fix to remove '-' from the comparison date labels to allow proper id recognition for the aria-describedby. Fixes b/195600299 * fix(material/datepicker): update goldens Updates goldens for previous fix. (cherry picked from commit e8d009f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Datepicker calendar-body .ts and .html files to add id values for if there is a comparison start/end date and to provide values to their respective html values to provide an aria-describedby value to be announced for screenreaders when comparison dates are present.
Before screenshot button no aria-describedby
Before screenshot no comparison date spans
Before fix screencast
After screenshot button aria-describedby
After screenshot span with respective aria-describedby id
After fix screencast
Fixes b/195600299