fix(cdk/portal): fix incorrect injector hierarchy with DomPortalOutlet and child environment injectors #30610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et` and child environment injectors This commit fixes a regression that was introduced in angular#27427, where the injector hierarchy did not respect nested environment injectors. `DomPortalOutlet` was always using the application root as environment injector, yet the element injector may have a custom child environment injector as ancestor. This child environment injector has to be retrieved manually and passed as environment injector of the portal component. Fixes angular#30609
JoostK
requested review from
andrewseguin and
crisbeto
and removed request for
a team
crisbeto
approved these changes
Mar 9, 2025
…peated non-null assertion This also has the benefit of minimizing more effectively, as the local variable can be renamed but the separate field accesses could not.
JoostK
force-pushed
the
cdk/portal/env-injector
branch
from
6399c2d to
7705be6
Compare
JeanMeche
approved these changes
Mar 9, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
pushed a commit
that referenced
this pull request
Mar 10, 2025
…t and child environment injectors (#30610) * fix(cdk/portal): fix incorrect injector hierarchy with `DomPortalOutlet` and child environment injectors This commit fixes a regression that was introduced in #27427, where the injector hierarchy did not respect nested environment injectors. `DomPortalOutlet` was always using the application root as environment injector, yet the element injector may have a custom child environment injector as ancestor. This child environment injector has to be retrieved manually and passed as environment injector of the portal component. Fixes #30609 * refactor(cdk/portal): store application in local variable to avoid repeated non-null assertion This also has the benefit of minimizing more effectively, as the local variable can be renamed but the separate field accesses could not. (cherry picked from commit d0d5de4)
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression that was introduced in #27427, where the injector hierarchy
did not respect nested environment injectors.
DomPortalOutletwas always using the applicationroot as environment injector, yet the element injector may have a custom child environment injector
as ancestor. This child environment injector has to be retrieved manually and passed as environment
injector of the portal component.
Fixes #30609