Skip to content

More changes to migrate to ts_project #30704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

More changes to migrate to ts_project #30704

merged 2 commits into from
Mar 25, 2025

Conversation

@devversion
Copy link
Member

See individual commits

@devversion
build: fix ts_project interop causing conflicting mappings
ac5732a 
The `ts_project` interop currently conflicts with some mappings from
e.g. `ts_library`. This can happen when the same target is transitively
referenced via the interop, or directly in e.g. `ng_module` still.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 25, 2025
@devversion
build: migrate all ng_test_library targets to ts_project
72359eb 
Migrates all `ng_test_library` targets to `ts_project`.
@devversion devversion requested a review from crisbeto March 25, 2025 08:23
@devversion devversion added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 25, 2025
@devversion devversion marked this pull request as ready for review March 25, 2025 08:23
@devversion devversion requested review from a team as code owners March 25, 2025 08:23
@devversion devversion requested review from andrewseguin and removed request for a team March 25, 2025 08:23
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 25, 2025
@devversion devversion removed request for a team and andrewseguin March 25, 2025 12:44
@devversion devversion added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 25, 2025
@devversion devversion merged commit ba5cf3d into angular:main Mar 25, 2025
27 of 29 checks passed
@devversion devversion mentioned this pull request Mar 26, 2025
Merged
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
@devversion @mistrykaran91
More changes to migrate to ts_project (angular#30704)
5ceae40 
* build: fix `ts_project` interop causing conflicting mappings

The `ts_project` interop currently conflicts with some mappings from
e.g. `ts_library`. This can happen when the same target is transitively
referenced via the interop, or directly in e.g. `ng_module` still.

* build: migrate all `ng_test_library` targets to `ts_project`

Migrates all `ng_test_library` targets to `ts_project`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devversion @crisbeto