Skip to content

Conversation

@devversion
Copy link
Member

This completes the ts_library migration. Now ng_module is left.

See individual commits

The new version contains some changes to support `--traceResolution`,
which is useful for debugging.
The `rules_js` `npm_package` rule does not support nested NPM packages,
so we should stop doing that and instead use an idiomatic filegroup.
Migrates all `ng_e2e_test_library` targets to use `ts_project` directly.
This is simpler and more obvious.
This rule is no longer needed, so we can remove it from our macros.

Also removes patches for it.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 25, 2025
@devversion devversion requested a review from crisbeto March 26, 2025 07:42
@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 26, 2025
@devversion devversion marked this pull request as ready for review March 26, 2025 07:42
@devversion devversion requested review from a team as code owners March 26, 2025 07:42
@devversion devversion requested review from mmalerba and removed request for a team March 26, 2025 07:42
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 26, 2025
@devversion devversion removed request for a team and mmalerba March 26, 2025 08:32
@devversion devversion merged commit a9a3db3 into angular:main Mar 26, 2025
24 of 25 checks passed
@devversion devversion deleted the rjs-5 branch March 26, 2025 08:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants