Skip to content

test(cdk/overlay): change how renders are counted in test #30712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

test(cdk/overlay): change how renders are counted in test #30712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/cdk/overlay/dispatchers/overlay-outside-click-dispatcher.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {ApplicationRef, Component} from '@angular/core';
import {TestBed, inject} from '@angular/core/testing';
import {ApplicationRef, Component, afterRender} from '@angular/core';
import {filter, take} from 'rxjs/operators';
import {ComponentPortal} from '../../portal';
import {dispatchFakeEvent, dispatchMouseEvent} from '../../testing/private';
import {OverlayModule, Overlay} from '../index';
import {Overlay, OverlayModule} from '../index';
import {OverlayOutsideClickDispatcher} from './overlay-outside-click-dispatcher';
import {ComponentPortal} from '../../portal';
import {filter, take} from 'rxjs/operators';

describe('OverlayOutsideClickDispatcher', () => {
let appRef: ApplicationRef;
Expand Down Expand Up @@ -388,11 +388,13 @@ describe('OverlayOutsideClickDispatcher', () => {

it('should run change detection if the click was made outside the overlay and there are `outsidePointerEvents` observers', async () => {
let renders = 0;
TestBed.runInInjectionContext(() => {
afterRender(() => {
@Component({template: '{{increment()}}'})
class Counter {
increment() {
renders++;
});
});
}
}
TestBed.createComponent(Counter);
function stablePromise() {
return TestBed.inject(ApplicationRef)
.isStable.pipe(
Expand All @@ -402,7 +404,8 @@ describe('OverlayOutsideClickDispatcher', () => {
.toPromise();
}
await stablePromise();
expect(renders).toEqual(1);
renders = 0;
expect(renders).toEqual(0);
const portal = new ComponentPortal(TestComponent);
const overlayRef = overlay.create();
overlayRef.attach(portal);
Expand All @@ -412,16 +415,16 @@ describe('OverlayOutsideClickDispatcher', () => {
document.body.appendChild(context);

await stablePromise();
expect(renders).toEqual(2);
expect(renders).toEqual(1);
dispatchMouseEvent(context, 'click');
await stablePromise();
expect(renders).toEqual(2);
expect(renders).toEqual(1);

overlayRef.outsidePointerEvents().subscribe();

dispatchMouseEvent(context, 'click');
await stablePromise();
expect(renders).toEqual(2);
expect(renders).toEqual(1);
});
});
});
Expand Down
Loading