Skip to content

Add a null check to autocomplete options #30734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Add a null check to autocomplete options #30734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60650a3
fix a bug with null options
rileyajones Mar 27, 2025
f9244f1
Add a test
rileyajones Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/material/autocomplete/autocomplete-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,12 @@ export class MatAutocompleteTrigger
{injector: this._environmentInjector},
);
});
const optionChanges = this.autocomplete.options.changes.pipe(
const optionChanges = this.autocomplete.options?.changes.pipe(
tap(() => this._positionStrategy.reapplyLastPosition()),
// Defer emitting to the stream until the next tick, because changing
// bindings in here will cause "changed after checked" errors.
delay(0),
);
) ?? observableOf();

// When the options are initially rendered, and when the option list changes...
return (
Expand Down
2 changes: 1 addition & 1 deletion src/material/autocomplete/autocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class MatAutocomplete implements AfterContentInit, OnDestroy {

/** Panel should hide itself when the option list is empty. */
_setVisibility() {
this.showPanel = !!this.options.length;
this.showPanel = !!this.options?.length;
this._changeDetectorRef.markForCheck();
}

Expand Down
Loading