Skip to content

feat(cdk-experimental/tree): add tree directives, example, and tests #31350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

feat(cdk-experimental/tree): add tree directives, example, and tests #31350

merged 1 commit into from
Jun 17, 2025

Conversation

ok7sai
Copy link
Member

@ok7sai ok7sai commented Jun 12, 2025

No description provided.

@ok7sai ok7sai requested review from jelbourn and wagnermaciel June 12, 2025 23:20
@ok7sai ok7sai requested review from a team as code owners June 12, 2025 23:20
@ok7sai ok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Jun 12, 2025
@ok7sai ok7sai requested review from andrewseguin and removed request for a team June 12, 2025 23:20
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

Deployed dev-app for 06fcdc7 to: https://ng-dev-previews-comp--pr-angular-components-31350-dev-7ldbczh9.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@devversion devversion removed the request for review from a team June 13, 2025 07:16
wagnermaciel
wagnermaciel approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Very happy with the way registering nested tree items came out!

I noticed a small bug which might have to do with the list-selection behavior, not necessarily the tree implementation.

In a single select tree with explicit selection and skipDisabled: false, navigating to a disabled item and hitting space removes selection from the currently selected item.

We can probably just investigate this in a future PR.

wagnermaciel
wagnermaciel reviewed Jun 16, 2025
View reviewed changes
@ok7sai ok7sai force-pushed the ng-aria-tree-split branch 2 times, most recently from dfe8283 to 4199885 Compare June 17, 2025 18:31
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 17, 2025
@ok7sai ok7sai force-pushed the ng-aria-tree-split branch from 4199885 to 06fcdc7 Compare June 17, 2025 23:30
@ok7sai ok7sai merged commit 97d60c5 into angular:main Jun 17, 2025
20 of 22 checks passed
@ok7sai ok7sai deleted the ng-aria-tree-split branch June 17, 2025 23:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ok7sai @wagnermaciel