Add Auto-Scroll Support for RecyclerView in Multiselect View

[Scapesfear]

Purpose / Description

Fixes the missing auto-scroll functionality when switching to multi-select mode in RecyclerView, ensuring a smoother user experience.

Fixes

• Fixes Browser: keep selection visually stable #17747

Approach

This change adds the missing auto-scroll functionality, ensuring that the RecyclerView scrolls smoothly when entering multi-select mode, improving usability.

How Has This Been Tested?

Samsung F23 5G
https://github.com/user-attachments/assets/9b2dc926-2fbc-4a4c-b4df-7c44a461fc6f

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Outcome is good. Change seems much more complicated than it needs to be

[mikehardy]

A few comments

[david-allison]

This should be done in the ViewModel (with tests)

It should be simpler than we have now:

• Update onLongPress to provide the View as a parameter, so you don't need to look it up
• Perform the operation in the ViewModel, likely passing in the topOffset
• React to an event that the ViewModel emits

[david-allison]

Also to note: this doesn't handle the inverse: removing the selection is also visually unstable

[Scapesfear]

Also to note: this doesn't handle the inverse: removing the selection is also visually unstable

It works now , I fixed it.

[Scapesfear]

test2.mp4

[david-allison]

Much simpler, great job! One minor nitpick

If a test or a @NeedsTest could be added, it'd be great

[david-allison]

Almost there! Code's good, the positioning isn't quite right, I have a list of cards, some of which are multi-line questions, on a tablet

I get instances during testing where I can long press a row, deselect it, and the row under the cursor has changed

[Scapesfear]

Almost there! Code's good, the positioning isn't quite right, I have a list of cards, some of which are multi-line questions, on a tablet

I get instances during testing where I can long press a row, deselect it, and the row under the cursor has changed

@david-allison if could you send me a test video or something , it will be very useful.

[david-allison]

Great stuff, thanks so much!!!

[lukstbit]

@Scapesfear Please be patient and don't request reviews especially if the PR is not ready to be reviewed. You can see that the Github UI is telling you that there are conflicts, meaning code was added to the main branch while this branch was opened and now there are conflicts between the current application code on main and the changes that were done in this PR. Your job is to fix those conflicts and update the PR so it can be merged(also squash the commits into one commit).

[Scapesfear]

@Scapesfear Please be patient and don't request reviews especially if the PR is not ready to be reviewed. You can see that the Github UI is telling you that there are conflicts, meaning code was added to the main branch while this branch was opened and now there are conflicts between the current application code on main and the changes that were done in this PR. Your job is to fix those conflicts and update the PR so it can be merged(also squash the commits into one commit).

done, fixed the merge conflicts and squash-merged the commits in one.

[BrayanDSO]

LGTM. Thanks

[mikehardy]

Nice one!