Fix minor UI issue for fab in landscape orientation#17861
Merged
mikehardy merged 1 commit intoankidroid:mainfrom Jan 26, 2025
Merged
Fix minor UI issue for fab in landscape orientation#17861mikehardy merged 1 commit intoankidroid:mainfrom
mikehardy merged 1 commit intoankidroid:mainfrom
Conversation
In landscape the main FAB wasn't preserving its starting when expanded and this resulted in its icon being positioned incorrectly inside. The fix is wrapping the entire FAB's layout in a ScrollView which should give the FAB sufficient space to keep its original dimension.
david-allison
approved these changes
Jan 24, 2025
4 tasks
Member
|
Hi there @lukstbit! This is the OpenCollective Notice for PRs merged from 2025-01-01 through 2025-01-31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the fab isn't displayed properly when expanded in landscape orientation so I added a ScrollView to make more space available. The changes are mostly indentation, review with Hide whitespace. See images:
bug-landscape/fixed-landscape/fixed-portrait
How Has This Been Tested?
Checked both orientations.
Checklist