Skip to content

Fix minor UI issue for fab in landscape orientation#17861

Merged
mikehardy merged 1 commit intoankidroid:mainfrom
lukstbit:fix_fabLandscape
Jan 26, 2025
Merged

Fix minor UI issue for fab in landscape orientation#17861
mikehardy merged 1 commit intoankidroid:mainfrom
lukstbit:fix_fabLandscape

Conversation

@lukstbit
Copy link
Member

@lukstbit lukstbit commented Jan 23, 2025

Currently the fab isn't displayed properly when expanded in landscape orientation so I added a ScrollView to make more space available. The changes are mostly indentation, review with Hide whitespace. See images:

bug-landscape/fixed-landscape/fixed-portrait

fab_landscapefab_fixed_landscapefab_portrait

How Has This Been Tested?

Checked both orientations.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

In landscape the main FAB wasn't preserving its starting when expanded
and this resulted in its icon being positioned incorrectly inside. The fix is
wrapping the entire FAB's layout in a ScrollView which should give the FAB
sufficient space to keep its original dimension.
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 24, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thanks!

@mikehardy mikehardy added this pull request to the merge queue Jan 26, 2025
Merged via the queue into ankidroid:main with commit 2f656e0 Jan 26, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jan 26, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Jan 26, 2025
@david-allison david-allison mentioned this pull request Jan 27, 2025
4 tasks
@lukstbit lukstbit deleted the fix_fabLandscape branch January 27, 2025 18:11
@david-allison
Copy link
Member

Hi there @lukstbit! This is the OpenCollective Notice for PRs merged from 2025-01-01 through 2025-01-31

Starting 2025, we have updated our selection process for Open Collective, and you are eligible for compensation for your work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

This note applies to all PRs merged for this month.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants