Label of deck deletion icon becomes "Delete deck"#18371
Merged
Arthur-Milchior merged 1 commit intoankidroid:mainfrom May 29, 2025
Merged
Label of deck deletion icon becomes "Delete deck"#18371Arthur-Milchior merged 1 commit intoankidroid:mainfrom
Arthur-Milchior merged 1 commit intoankidroid:mainfrom
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
BrayanDSO
reviewed
May 26, 2025
| } | ||
| R.id.action_deck_delete -> { | ||
| launchCatchingTask { | ||
| // The progress message is actually "Deleting deck" and not "delete deck" as indicated by the resource name. |
Member
There was a problem hiding this comment.
I don't think this comment is necessary. Same for the other place you added it
BrayanDSO
approved these changes
May 26, 2025
BrayanDSO
added
the
Needs Second Approval
david-allison
approved these changes
May 27, 2025
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Same comment as Brayan. Implementer's choice
david-allison
added
Needs Author Reply
It used to be "Deleting deck…" which was not appropriate for a button.
Arthur-Milchior
force-pushed
the
delete_deck
branch
from
28168e8 to
842ec2a
Compare
Member
Author
|
Removed |
Contributor
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
github-actions
bot
removed
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be "Deleting deck…" which was not appropriate for a button.