Skip to content

fix(card-browser): note editor fragment updated browser deck#18476

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:18462
Jun 11, 2025
Merged

fix(card-browser): note editor fragment updated browser deck#18476
BrayanDSO merged 1 commit intoankidroid:mainfrom
david-allison:18462

Conversation

@david-allison
Copy link
Member

Fixes

Approach

Prefer the parent fragment over the activity when finding DeckSelectionListener

How Has This Been Tested?

API 34 tablet emulator

Learning (optional, can help others)

I have a more involved fix, but this was really easy after #18463 was merged

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Prefer the parent fragment over the activity when finding `DeckSelectionListener`

Fixes 18462
@david-allison david-allison added the Review High Priority Request for high priority review label Jun 11, 2025
@BrayanDSO
Copy link
Member

Just by taking a glance, I get why it needs a more involved fix

@BrayanDSO BrayanDSO added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 11, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Jun 11, 2025
@david-allison
Copy link
Member Author

david-allison commented Jun 11, 2025

Nightmare of a class: we originally had a spinner, then moved to a dialog, but kept the 'spinner' functionality around.

The actual dialog isn't too bad

Merged via the queue into ankidroid:main with commit 01553a2 Jun 11, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jun 11, 2025
@github-actions github-actions bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browse (split screen): changing deck in note editor updates the browser instead

2 participants