fix(card-browser): note editor fragment updated browser deck#18476
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Jun 11, 2025
Merged
fix(card-browser): note editor fragment updated browser deck#18476BrayanDSO merged 1 commit intoankidroid:mainfrom
BrayanDSO merged 1 commit intoankidroid:mainfrom
Conversation
Prefer the parent fragment over the activity when finding `DeckSelectionListener` Fixes 18462
BrayanDSO
approved these changes
Jun 11, 2025
Member
|
Just by taking a glance, I get why it needs a more involved fix |
Member
Author
|
Nightmare of a class: we originally had a spinner, then moved to a dialog, but kept the 'spinner' functionality around. The actual dialog isn't too bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Approach
Prefer the parent fragment over the activity when finding
DeckSelectionListenerHow Has This Been Tested?
API 34 tablet emulator
Learning (optional, can help others)
I have a more involved fix, but this was really easy after #18463 was merged
Checklist