Skip to content

fix(card-browser): note editor fragment updated browser deck #18476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 1 commit into from
Jun 11, 2025
Merged

fix(card-browser): note editor fragment updated browser deck #18476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckSelectionDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import com.ichi2.anki.R
import com.ichi2.anki.analytics.AnalyticsDialogFragment
import com.ichi2.anki.common.utils.annotation.KotlinCleanup
import com.ichi2.anki.dialogs.DeckSelectionDialog.DecksArrayAdapter.DecksFilter
import com.ichi2.anki.dialogs.DeckSelectionDialog.SelectableDeck
import com.ichi2.anki.launchCatchingTask
import com.ichi2.anki.showThemedToast
import com.ichi2.annotations.NeedsTest
Expand Down Expand Up @@ -247,23 +246,22 @@ open class DeckSelectionDialog : AnalyticsDialogFragment() {
if (field != null) {
return field
}
val parentFragment = parentFragment
if (parentFragment is DeckSelectionListener) {
return parentFragment
}
val activity: Activity = requireActivity()
if (activity is DeckSelectionListener) {
return activity
}
val parentFragment = parentFragment
if (parentFragment is DeckSelectionListener) {
return parentFragment
} else {
// try to find inside the activity an active fragment that is a DeckSelectionListener
val foundAvailableFragments =
parentFragmentManager.fragments.filter {
it.isResumed && it is DeckSelectionListener
}
if (foundAvailableFragments.isNotEmpty()) {
// if we found at least one resumed candidate fragment use it
return foundAvailableFragments[0] as DeckSelectionListener
// try to find inside the activity an active fragment that is a DeckSelectionListener
val foundAvailableFragments =
parentFragmentManager.fragments.filter {
it.isResumed && it is DeckSelectionListener
}
if (foundAvailableFragments.isNotEmpty()) {
// if we found at least one resumed candidate fragment use it
return foundAvailableFragments[0] as DeckSelectionListener
}
throw IllegalStateException("Neither activity or any fragment in the activity were a selection listener")
}
Expand Down