Skip to content

refactor: rename 'replay audio' to 'replay media'#18492

Merged
david-allison merged 3 commits intoankidroid:mainfrom
david-allison:18442-remove-media
Jun 13, 2025
Merged

refactor: rename 'replay audio' to 'replay media'#18492
david-allison merged 3 commits intoankidroid:mainfrom
david-allison:18442-remove-media

Conversation

@david-allison
Copy link
Member

Aside from in Bindings, as this is stored in Preferences

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

BrayanDSO
BrayanDSO previously approved these changes Jun 12, 2025
@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Jun 12, 2025
@david-allison david-allison requested a review from BrayanDSO June 12, 2025 20:26
@david-allison
Copy link
Member Author

re-requesting review: second commit added

If it's controversial, let's split them out

@david-allison david-allison force-pushed the 18442-remove-media branch 4 times, most recently from 2e8cffa to 2709a04 Compare June 12, 2025 20:41
@david-allison david-allison dismissed BrayanDSO’s stale review June 12, 2025 20:41

need to do this as well

Aside from in Bindings, as this is stored in Preferences

Part of 18442
Video is now included

Use 'media', 'AvTag', or remove the 'sound' suffix

Part of issue 18442
* remove unused variable
* remove `suspend`
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renames. Still LGTM

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, leaving this open for now seeing the request for review for Arthur.

The strings are clean :

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jun 13, 2025
@david-allison
Copy link
Member Author

I'll get this in to stop it atrophying/needing another sync

@david-allison david-allison added this pull request to the merge queue Jun 13, 2025
Merged via the queue into ankidroid:main with commit 3ffc30a Jun 13, 2025
9 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Jun 13, 2025
@github-actions
Copy link
Contributor

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 13, 2025
@david-allison david-allison deleted the 18442-remove-media branch June 16, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants