Skip to content

Prefs for review reminder entry points#18828

Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-review-reminders-prefs
Jul 11, 2025
Merged

Prefs for review reminder entry points#18828
BrayanDSO merged 1 commit intoankidroid:mainfrom
ericli3690:ericli3690-review-reminders-prefs

Conversation

@ericli3690
Copy link
Member

@ericli3690 ericli3690 commented Jul 10, 2025 •
edited
Loading

Purpose / Description

  • Used Prefs for review reminder entry points since it is more concise compared to requireContext().sharedPrefs()
  • Renamed vague "enableReviewReminder" variables to be more clearer, ex. "newReviewRemindersAreEnabled"

Fixes

  • For GSoC 2025: Review Reminders

Approach

  • Renamed variables and used Prefs as recommended by David

How Has This Been Tested?

  • Tested on a physical Samsung S23, API 34.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code

@ericli3690 ericli3690 added GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors Needs Review and removed Needs Review labels Jul 10, 2025
@ericli3690 ericli3690 marked this pull request as draft July 10, 2025 04:21
@ericli3690 ericli3690 force-pushed the ericli3690-review-reminders-prefs branch from d5fc83e to a59fa41 Compare July 10, 2025 04:22
@ericli3690 ericli3690 marked this pull request as ready for review July 10, 2025 04:45
david-allison
david-allison reviewed Jul 10, 2025
View reviewed changes
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jul 10, 2025
@ericli3690
Prefs for review reminder entry points
4c8bd83 
- Renamed `pref_new_notifications` to `pref_new_review_reminders` in fitting with the standardized name of this feature
- Declared a new Pref delegate, `newReviewRemindersEnabled`, and used it at all entry points that check if new review reminders are enabled
@ericli3690 ericli3690 force-pushed the ericli3690-review-reminders-prefs branch from a59fa41 to 4c8bd83 Compare July 11, 2025 01:31
@ericli3690 ericli3690 removed Needs Author Reply Waiting for a reply from the original author Has Conflicts labels Jul 11, 2025
david-allison
david-allison approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 11, 2025
BrayanDSO
BrayanDSO approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrayanDSO BrayanDSO added this pull request to the merge queue Jul 11, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 11, 2025
Merged via the queue into ankidroid:main with commit 36f9c9b Jul 11, 2025
9 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 11, 2025
@github-actions github-actions bot added this to the 2.22 release milestone Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-allison david-allison david-allison approved these changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

GSoC Pull requests authored by a Google Summer of Code participant [Candidate/Selected], for GSoC mentors

Projects

None yet

Milestone

2.22 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ericli3690 @david-allison @BrayanDSO