Editing notes triggers the timebox popup

[Aryan171]

Purpose / Description

Previously, the timebox limit was checked whenever the updateCurrentCard function was called, which lead to unnecessary timebox reached popup, this logic has been moved to the answerCardInner function. This makes it so that the popup is only shown when a card has been answered.

Fixes

• Fixes Editing notes triggers the timebox popup #18374

How Has This Been Tested?

Tested on an android 15 phone

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Cheers! Sorry this sat. Notification queue got really backlogged

[david-allison]

This seems reasonable: the same call is made in currentQueueState

[mikehardy]

great stuff, thank you!

[mikehardy]

note, from a "conventional commits" standpoint, which is frequently used in combination with "semantic release" so that a release flow can be fully automated and select the correct semantic version type between major, minor, or patch release - I would clearly classify this as a "fix" and it should generate a patch release. But you tagged the commit as "feat" which would be a new feature and generate a minor version. That is not something this project enforces, but since you put it in there I thought I'd note the correction. I squashed this PR when merging so I had a chance to edit the commit message, and I switched it from feat to fix. Cheers