Skip to content

Editing notes triggers the timebox popup #19451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2025
Merged

Editing notes triggers the timebox popup #19451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,11 +1208,16 @@ open class Reviewer :
topCard.renderOutput(this@withCol, reload = true)
}
}
state?.timeboxReached?.let { dealWithTimeBox(it) }

currentCard = state?.topCard
queueState = state
}

/**
* Answer the current card, update the scheduler and checks if the timebox limit has been reached
* and, if so, displays a dialog to the user
* @param rating The user's rating for the card
*/
override suspend fun answerCardInner(rating: Rating) {
val state = queueState!!
val cardId = currentCard!!.id
Expand All @@ -1235,6 +1240,12 @@ open class Reviewer :
showSnackbar(leechMessage, Snackbar.LENGTH_SHORT)
}
}

// showing the timebox reached dialog if the timebox is reached
val timebox = withCol { timeboxReached() }
Copy link
Member

@david-allison david-allison Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable: the same call is made in currentQueueState

if (timebox != null) {
dealWithTimeBox(timebox)
}
}

private suspend fun dealWithTimeBox(timebox: Collection.TimeboxReached) {
Expand Down