AAP-47499 Use get_settings to get CSRF_TRUSTED_ORIGINS in ansible_base SessionAuthentication #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use get_setting - Add AnsibleBaseCsrfViewMiddleware that reads CSRF_TRUSTED_ORIGINS using ansible_base.lib.utils.settings.get_setting instead of directly from Django settings - Override all three cached properties (csrf_trusted_origins_hosts, allowed_origins_exact, allowed_origin_subdomains) to use get_setting for dynamic configuration - Add AnsibleBaseCSRFCheck class that inherits from AnsibleBaseCsrfViewMiddleware - Modify SessionAuthentication.enforce_csrf to use AnsibleBaseCSRFCheck instead of Django's default CSRFCheck - Add comprehensive tests for both middleware and session authentication CSRF functionality - Enables CSRF_TRUSTED_ORIGINS to be dynamically loaded from various sources via ANSIBLE_BASE_SETTINGS_FUNCTION while maintaining backward compatibility
|
I'll see how SonarCloud handles this one before I add some testing. |
|
Is this a rework of #742? Ping @TheRealHaoLiu |
AlanCoding
approved these changes
Jul 8, 2025
Closed
11 tasks
|
DVCS PR Check Results: PR appears valid (JIRA key(s) found) |
|
john-westcott-iv
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ansible_base.lib.utils.settings.get_settingType of Change
Self-Review Checklist
Testing Instructions
Prerequisites
Run your django app with one worker for simplicity (we cannot guarantee this in testing situations, so this is only for manual verification)
Steps to Test
Originheader to match an element of your alternate CSRF_TRUSTED_ORIGINSExpected Results