-
Notifications
You must be signed in to change notification settings - Fork 81
AAP-47499 Use get_settings to get CSRF_TRUSTED_ORIGINS in ansible_base SessionAuthentication #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,31 @@ | ||
from django.conf import settings | ||
from rest_framework import authentication | ||
|
||
from ansible_base.lib.utils.settings import get_setting | ||
|
||
|
||
class SessionAuthentication(authentication.SessionAuthentication): | ||
""" | ||
This class allows us to fail with a 401 if the user is not authenticated. | ||
Uses AnsibleBaseCsrfViewMiddleware for CSRF checking instead of Django's | ||
default CsrfViewMiddleware, allowing CSRF_TRUSTED_ORIGINS to be read | ||
dynamically using get_setting. | ||
""" | ||
|
||
def authenticate_header(self, request): | ||
return "Session" | ||
|
||
def enforce_csrf(self, request): | ||
""" | ||
Enforce CSRF validation for session based authentication using | ||
AnsibleBaseCsrfViewMiddleware instead of Django's CsrfViewMiddleware. | ||
""" | ||
csrf_trusted_origins = settings.CSRF_TRUSTED_ORIGINS | ||
try: | ||
# Temporarily patch the setting | ||
settings.CSRF_TRUSTED_ORIGINS = get_setting("CSRF_TRUSTED_ORIGINS", csrf_trusted_origins) | ||
return super().enforce_csrf(request) | ||
finally: | ||
# Revert setting after this is done | ||
settings.CSRF_TRUSTED_ORIGINS = csrf_trusted_origins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.