-
Notifications
You must be signed in to change notification settings - Fork 8
fix: add home section #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…hinx-theme into feat/home-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/ansys_sphinx_theme/__init__.py
Outdated
return | ||
|
||
home_entry = ( | ||
nodes.Text("Package Home"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we imposing this to always be Package Home
? I thought we agreed on just writing Home
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mia suggested having the package at home in this comment last week, but we can discuss this further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.. "Package Home" looks too verbose and weird .. I'd sugggest moving to "Home"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like Package Home
is too long.. Home
is consistent with the logo 🏠 we see in the breadcrumps. To me @mia-guo-ux didn't mean Package
in the label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinging @mia-guo-ux here , for insights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid confusion, we initially adopted the term Package Home
, since Home
alone could be misinterpreted as referring to the broader PyAnsys home.
One potential improvement would be to simplify the label to just Home
, while providing additional context through a tooltip. For example, hovering over "Home" could display a tooltip
like PyAEDT Home
, clearly indicating the specific package being referenced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the tool tip, and renamed to home
Fix #702, fix #498, fix #257