-
Notifications
You must be signed in to change notification settings - Fork 8
fix: add home section #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Revathyvenugopal162
wants to merge
22
commits into
main
Choose a base branch
from
feat/home-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bfe36b5
fix: add home section
Revathyvenugopal162 432099c
chore: adding changelog file 769.fixed.md [dependabot-skip]
pyansys-ci-bot dd419c4
Merge branch 'main' into feat/home-section
Revathyvenugopal162 7c28eb2
fix: update the precommit
Revathyvenugopal162 9505bb2
Merge branch 'feat/home-section' of https://github.com/ansys/ansys-sp…
Revathyvenugopal162 667e260
fix: add docstree resolve
Revathyvenugopal162 9329a63
fix: add docstree resolve
Revathyvenugopal162 b92a0ee
fix: remove html context
Revathyvenugopal162 b70964e
fix: cleanup the docresolve
Revathyvenugopal162 51c4aa3
fix: strict logo link
Revathyvenugopal162 7fb8c85
fix: precommit
Revathyvenugopal162 a7bd29c
Merge branch 'main' into feat/home-section
Revathyvenugopal162 dddae72
fix: update any
Revathyvenugopal162 5cc571b
fix: update the check
Revathyvenugopal162 ec08c2c
fix: update pre-commit
Revathyvenugopal162 15a45e6
Merge branch 'main' into feat/home-section
Revathyvenugopal162 e458be1
chore: adding changelog file 769.fixed.md [dependabot-skip]
pyansys-ci-bot 5ae077c
Merge branch 'main' into feat/home-section
Revathyvenugopal162 ed462df
feat: add tooltip
Revathyvenugopal162 918dacb
fix: codestyle
Revathyvenugopal162 945e5a6
fix: depedencies
Revathyvenugopal162 b504bf9
Merge branch 'main' into feat/home-section
Revathyvenugopal162 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add home section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we imposing this to always be
Package Home
? I thought we agreed on just writingHome
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mia suggested having the package at home in this comment last week, but we can discuss this further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.. "Package Home" looks too verbose and weird .. I'd sugggest moving to "Home"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like
Package Home
is too long..Home
is consistent with the logo 🏠 we see in the breadcrumps. To me @mia-guo-ux didn't meanPackage
in the label.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinging @mia-guo-ux here , for insights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germa89 @Revathyvenugopal162
To avoid confusion, we initially adopted the term
Package Home
, sinceHome
alone could be misinterpreted as referring to the broader PyAnsys home.One potential improvement would be to simplify the label to just
Home
, while providing additional context through a tooltip. For example, hovering over "Home" could display atooltip
likePyAEDT Home
, clearly indicating the specific package being referenced.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the tool tip, and renamed to home