Skip to content

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 5, 2025

Fix #702, fix #498, fix #257

Screenshot 2025-08-14 at 09 53 46 Screenshot 2025-08-14 at 09 57 56

@github-actions github-actions bot added the enhancement General improvements to existing features label Aug 5, 2025
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review August 6, 2025 12:41
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner August 6, 2025 12:41
Copy link
Contributor

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Revathyvenugopal162 Revathyvenugopal162 requested review from jorgepiloto and a team August 13, 2025 06:47
@Revathyvenugopal162 Revathyvenugopal162 added this to the v1.6 milestone Aug 25, 2025
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. I just requested some changes.

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for performing this PR @Revathyvenugopal162 !!! I left a minor comment.

Agreeing with @jorgepiloto's comment, would it be possible to reach the same result without using an extra dependency ? Note that my request for changes is about the project_name handling. I don't know if there is a simple / robust way to achieve the same result as the one you obtain with beautifulsoup4

@Revathyvenugopal162
Copy link
Contributor Author

Thanks for performing this PR @Revathyvenugopal162 !!! I left a minor comment.

Agreeing with @jorgepiloto's comment, would it be possible to reach the same result without using an extra dependency ?

yes, i am trying locally without using the package.

@Revathyvenugopal162
Copy link
Contributor Author

@jorgepiloto @SMoraisAnsys removed the bs4, and added tooltip with regex
Screenshot 2025-08-27 at 10 26 14

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking knowledge on the code associated to tooltip addition. However, it seems to make sense.

@Revathyvenugopal162 Revathyvenugopal162 enabled auto-merge (squash) August 27, 2025 09:10
@Revathyvenugopal162 Revathyvenugopal162 merged commit 0c497bd into main Aug 27, 2025
20 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/home-section branch August 27, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop allowing users to customize logo link Add home section in the navigation bar Modify the link from the pyansys logo in docs
8 participants