-
Notifications
You must be signed in to change notification settings - Fork 8
fix: add home section #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hinx-theme into feat/home-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. I just requested some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for performing this PR @Revathyvenugopal162 !!! I left a minor comment.
Agreeing with @jorgepiloto's comment, would it be possible to reach the same result without using an extra dependency ? Note that my request for changes is about the project_name
handling. I don't know if there is a simple / robust way to achieve the same result as the one you obtain with beautifulsoup4
yes, i am trying locally without using the package. |
d856615
to
9e9ccd7
Compare
@jorgepiloto @SMoraisAnsys removed the bs4, and added tooltip with regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lacking knowledge on the code associated to tooltip addition. However, it seems to make sense.
Co-authored-by: Sébastien Morais <[email protected]>
Fix #702, fix #498, fix #257