Skip to content

FEAT: Fresnel extension#6480

Open
Samuelopez-ansys wants to merge 128 commits intomainfrom
fresnel_extension
Open

FEAT: Fresnel extension#6480
Samuelopez-ansys wants to merge 128 commits intomainfrom
fresnel_extension

Conversation

@Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jul 30, 2025

Description

This pull request introduces a new Fresnel extension for HFSS, enabling extraction of Fresnel coefficients from Floquet port simulations for periodic structures. It adds documentation, integration into the extension catalog, and comprehensive system tests for the new functionality. Additionally, several improvements and bug fixes have been made across the codebase, including enhancements to excitation handling, logging, UI theming, and design exploration.

Fresnel Extension Integration

  • Added new Fresnel extension documentation (doc/source/User_guide/pyaedt_extensions_doc/hfss/fresnel.rst) detailing workflows, features, validation checks, requirements, and command-line usage.
  • Integrated Fresnel extension into the HFSS extension catalog

Testing for Fresnel Extension

  • Added comprehensive system tests for Fresnel extension UI, validation, and coefficient extraction, including edge cases and error handling (tests/system/extensions/test_fresnel.py).
  • Integrated Fresnel test project fixture and extended HFSS tests to cover Fresnel port and coefficient extraction scenarios (tests/system/general/test_hfss.py).

HFSS Excitation Handling Improvements

  • Improved filtering of excitation names to correctly handle modes and ensure proper mapping to boundary objects (src/ansys/aedt/core/application/analysis.py).

Logging and UI Enhancements

  • Fixed desktop logging behavior to disable logs in non-graphical mode and enabled logs by default in extensions
  • Improved UI theming by applying custom colors and fonts to SpinBox widgets

Design Exploration Bug Fix

  • Corrected setup name mapping in design exploration to use the correct identifier

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys
Copy link
Member Author

Hi @maxcapodi78 @SMoraisAnsys, could you please review this new extension?

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the behavior as I don't have the AEDT version but I left some comments.
Would it be possible to improve a bit the extension UI layout ? :)

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft March 23, 2026 08:03
@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review March 23, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants