Open
Conversation
# Conflicts: # src/ansys/aedt/core/extensions/hfss/toolkits_catalog.toml
Member
Author
|
Hi @maxcapodi78 @SMoraisAnsys, could you please review this new extension? |
Collaborator
SMoraisAnsys
left a comment
There was a problem hiding this comment.
I can't test the behavior as I don't have the AEDT version but I left some comments.
Would it be possible to improve a bit the extension UI layout ? :)
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Eduardo Blanco <eduardo.blancofernandez@ansys.com>
… in FresnelExtension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new Fresnel extension for HFSS, enabling extraction of Fresnel coefficients from Floquet port simulations for periodic structures. It adds documentation, integration into the extension catalog, and comprehensive system tests for the new functionality. Additionally, several improvements and bug fixes have been made across the codebase, including enhancements to excitation handling, logging, UI theming, and design exploration.
Fresnel Extension Integration
doc/source/User_guide/pyaedt_extensions_doc/hfss/fresnel.rst) detailing workflows, features, validation checks, requirements, and command-line usage.Testing for Fresnel Extension
tests/system/extensions/test_fresnel.py).tests/system/general/test_hfss.py).HFSS Excitation Handling Improvements
src/ansys/aedt/core/application/analysis.py).Logging and UI Enhancements
Design Exploration Bug Fix
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist