-
Notifications
You must be signed in to change notification settings - Fork 226
FEAT: Fresnel extension #6480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samuelopez-ansys
wants to merge
129
commits into
main
Choose a base branch
from
fresnel_extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FEAT: Fresnel extension #6480
Changes from 110 commits
Commits
Show all changes
129 commits
Select commit
Hold shift + click to select a range
19dd936
Fresnel table
Samuelopez-ansys a82bd3b
Angular resolution
Samuelopez-ansys 170ec90
Merge branch 'main' into fresnel_extension
Samuelopez-ansys de606da
More Fresnel
Samuelopez-ansys 64c1835
Simulation settings
Samuelopez-ansys a0d0148
Get fresnel coefficients
Samuelopez-ansys 752659a
Get fresnel coefficients
Samuelopez-ansys 39a39ff
Fix typos
Samuelopez-ansys 0e056fa
Fix typos
Samuelopez-ansys db8e58c
Fix typos
Samuelopez-ansys 98fa995
Fix typos
Samuelopez-ansys 4235541
Rename rttbl
Samuelopez-ansys 88b5287
Add doc
Samuelopez-ansys b7eff19
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 8d26655
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 077173f
Get floquet port position
Samuelopez-ansys 579843f
Add fresnel unit test
Samuelopez-ansys ec00972
Add fresnel unit test
Samuelopez-ansys 5c03b28
Add fresnel unit test
Samuelopez-ansys 283c918
Merge branch 'main' into fresnel_extension
Samuelopez-ansys c4d1c31
Anisotropic
Samuelopez-ansys 8c0306f
Add suggestions
Samuelopez-ansys 69663a3
Fix Fresnel
Samuelopez-ansys c29b9ec
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 79ca29b
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 9dcbda8
Fix issues
Samuelopez-ansys 43a1b82
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 88bc748
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 8af61cd
Apply changes
Samuelopez-ansys c2b039c
Move simulation settings
Samuelopez-ansys 0c39172
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 60a3e7f
Fix codacy
Samuelopez-ansys 143de64
Merge branch 'main' into fresnel_extension
Samuelopez-ansys f709119
Fix errors
Samuelopez-ansys bb27371
Fix errors
Samuelopez-ansys e718501
Fix errors
Samuelopez-ansys 8f75ec2
Modify rttbl comments
VladimirIL 0fb2822
Merge branch 'main' into fresnel_extension
VladimirIL f61beaf
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 4d3c1bd
Allow higher Floquet Modes in the port definition
VladimirIL 2a3d680
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
VladimirIL e51cabc
Changes in FP modes error message
VladimirIL f8686e7
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] bf414fe
Write phi=360 which is a duplicate of phi=0 case
Samuelopez-ansys 900ef28
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 6a1bf6c
Split create variables and create coefficients
Samuelopez-ansys 3c5df50
Check if 360 is defined
Samuelopez-ansys 3e09cae
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 38832dc
Fix to disable anisotropic until 2026R1
Samuelopez-ansys e4b3995
Comment ThetaMax line for the isotropic scenario
VladimirIL ea8a5de
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 61ae84f
Bug fixes for the isotropic case and limitations related to ThetaMax …
VladimirIL 38d28ff
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] e13faa8
Fix to disable anisotropic until 2026R2
Samuelopez-ansys 04b724a
Set phi_max = 0 for the isotropic scenario for the correct computatio…
VladimirIL 925170f
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
Samuelopez-ansys b9558c5
Check AEDT version for the anisotropic scenario
VladimirIL a6fa5b5
Extraction validations
Samuelopez-ansys 2573ffa
Extraction validations
Samuelopez-ansys 4407626
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
Samuelopez-ansys a70710d
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 11abbd6
Check AEDT version for Isotropic RTTBL format
VladimirIL 2843435
Rollback one of checks in the previous push
VladimirIL b4a1483
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 72b952e
Add theta filtering
Samuelopez-ansys b46a185
Fix new solution data
Samuelopez-ansys b1cefa2
Improve tests
Samuelopez-ansys 80515c3
Improve tests
Samuelopez-ansys 37b8a99
Merge branch 'main' into fresnel_extension
Samuelopez-ansys f0974c3
Validation
Samuelopez-ansys 483c398
Merge branch 'main' into fresnel_extension
Samuelopez-ansys fd4473e
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 57d66d2
Merge conflicts
Samuelopez-ansys 43b187c
Desktop log should not be override
Samuelopez-ansys 79a20be
Add log to export dir
Samuelopez-ansys bbb8202
Add documentation
Samuelopez-ansys 5e382f4
Add documentation
Samuelopez-ansys c41c902
Add output variables for angles of incidence
VladimirIL 7eced58
Renormalize T coefficients
VladimirIL eecbae3
Fix a missed variable renaming
VladimirIL 7346493
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] f2b1408
REF: Update copyright year to 2026 and improve type hints across mult…
Samuelopez-ansys 69a74a1
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 9db7825
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 44ce98c
REF: Refactor variable creation and update angle calculations in HFSS…
Samuelopez-ansys 497ba54
REF: Improve phase shift calculations and ensure ascending order of P…
Samuelopez-ansys 3e09ae3
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 8dcf5ec
Fix the possibility of incorrect floating-point rounding representation
VladimirIL 34c013c
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 006df34
Merge branch 'main' into fresnel_extension
Samuelopez-ansys c27c10b
REF: Prevent desktop release on exception and enhance face assignment…
Samuelopez-ansys f97dda7
REF: Enhance Fresnel coefficient calculations to support isotropic an…
Samuelopez-ansys ddfbc92
Enhance isotropic/anisotropic detection in HFSS module with logging
Samuelopez-ansys eaf42c6
Fix theta_step calculation to ensure unique angle values in HFSS module
Samuelopez-ansys f471651
Fix theta_step calculation to ensure unique angle values in HFSS module
Samuelopez-ansys f7e84f7
Add test
Samuelopez-ansys 6d2efd6
Revision of documentation for the Fresnel Extension
VladimirIL bb5295f
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
Samuelopez-ansys 98e4c37
Update Fresnel extension to support version checks and enhance UI int…
Samuelopez-ansys dfc8cdb
Update Fresnel extension to support version checks and enhance UI int…
Samuelopez-ansys b0b186d
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 1380dba
ENHANCE: Add error handling for Floquet ports and improve code coverage
Samuelopez-ansys 1a8d919
Merge branch 'main' into fresnel_extension
Samuelopez-ansys c065d28
chore: adding changelog file 6480.added.md [dependabot-skip]
pyansys-ci-bot ec92a80
DOCS: Update Fresnel extension documentation for consistency and clarity
Samuelopez-ansys 83f9cb3
REFactor: remove redundant test for coefficient mode in Fresnel exten…
Samuelopez-ansys f9d17a5
DOCS: Correct formatting of section title in Fresnel extension docume…
Samuelopez-ansys 4c16f5d
ENHANCE: Add is_isotropic parameter to get_fresnel_coefficients function
Samuelopez-ansys 0b2d27f
ENHANCE: Add Floquet port creation in test_fresnel.py for improved te…
Samuelopez-ansys 7a89252
Merge branch 'main' into fresnel_extension
Samuelopez-ansys f60ee2c
Update src/ansys/aedt/core/application/analysis.py
Samuelopez-ansys 0a1f050
Update src/ansys/aedt/core/extensions/hfss/fresnel.py
Samuelopez-ansys 017c65d
REFAC: Remove unnecessary comments from button widget definitions in …
Samuelopez-ansys b62eacd
REFAC: Remove unnecessary comments from button widget definitions in …
Samuelopez-ansys d080b04
Update src/ansys/aedt/core/extensions/hfss/fresnel.py
Samuelopez-ansys de4b70b
REFAC: Remove redundant desktop logging setting in misc.py
Samuelopez-ansys b35a1cc
REFAC: Simplify desktop logging settings in desktop.py
Samuelopez-ansys d85ae7c
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
Samuelopez-ansys a8ddc48
REFAC: Remove redundant return statement in hfss.py
Samuelopez-ansys 8643f2f
Update src/ansys/aedt/core/application/analysis.py
Samuelopez-ansys cd58849
Merge remote-tracking branch 'origin/fresnel_extension' into fresnel_…
Samuelopez-ansys c3f5fb6
Merge branch 'main' into fresnel_extension
Samuelopez-ansys 799bdfa
REFAC: Update create_output_variable parameters for improved clarity
Samuelopez-ansys 5509d97
REFAC: Simplify elevation and azimuth resolution initialization in fr…
Samuelopez-ansys fc2af98
DOC: Add documentation URL for Fresnel extension in toolkits_catalog.…
Samuelopez-ansys 23bf35b
REFAC: Update net primitives access to use layout in cutout and solve…
Samuelopez-ansys 72afd23
REFAC: Remove "PASS" and "FAIL" indicators from UI validation message…
Samuelopez-ansys 2146cc8
REFAC: Remove hardcoded window dimensions and initialize fresnel_type…
Samuelopez-ansys d3c0024
Merge branch 'main' into fresnel_extension
Samuelopez-ansys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fresnel extension |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
doc/source/User_guide/pyaedt_extensions_doc/hfss/fresnel.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| Fresnel coefficients (RTTBL extraction) | ||
| ======================================= | ||
|
|
||
| With this extension, you can export Fresnel Coefficients for periodic structures from an HFSS Unit-Cell design with | ||
| Floquet ports in the RTTBL file format for further use in SBR+ for Fresnel (SBR+) Boundary Condition assignment. | ||
|
|
||
| You can access the extension from the icon created on the **Automation** tab using the Extension Manager. | ||
|
|
||
| Features | ||
| -------- | ||
|
|
||
| The extension supports two regimes for processing Fresnel Coefficients: | ||
|
|
||
| * **Isotropic**: Scans over the elevation angle (theta) only - coupling between the TE and TM polarizations is not considered | ||
| * **Anisotropic**: Scans over both elevation (theta) and azimuth (phi) angles (not available yet) - considering the polarization coupling | ||
|
|
||
| Workflows | ||
| --------- | ||
|
|
||
| The extension provides two workflow tabs: | ||
|
|
||
| Extraction workflow | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Extract Fresnel coefficients from existing analysis results for a setup with parametric sweep. | ||
|
|
||
| 1. Select a simulation setup and sweep | ||
| 2. Click **Validate** to verify the design configuration | ||
| 3. Click **Start** to extract the coefficients | ||
|
|
||
| .. image:: ../../../_static/extensions/fresnel_extraction.png | ||
| :width: 800 | ||
| :alt: Fresnel Extraction workflow | ||
|
|
||
| Advanced workflow | ||
| ~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Configure and run a new parametric analysis: | ||
|
|
||
| 1. Select a simulation setup | ||
| 2. Define the frequency sweep range (start, stop, step, units) | ||
| 3. Set angular resolution (coarse, regular, or fine) for theta and phi (only for the Anisotropic regime) | ||
| 4. Set the maximum theta scan value | ||
| 5. Click **Apply and Validate** to create the parametric setup | ||
| 6. Click **Start** to run the analysis and extract coefficients | ||
|
|
||
| .. image:: ../../../_static/extensions/fresnel_advanced.png | ||
| :width: 800 | ||
| :alt: Fresnel Advanced Workflow | ||
|
|
||
| Simulation settings | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This tab is to configure HPC and Parametric Sweep options: | ||
|
|
||
| * **HPC Options**: Set number of cores and tasks | ||
| * **Optimetrics Options**: Enable mesh reuse across variations | ||
|
|
||
| .. image:: ../../../_static/extensions/fresnel_settings.png | ||
| :width: 800 | ||
| :alt: Fresnel Simulation Settings | ||
|
|
||
| Validation checks | ||
| ----------------- | ||
|
|
||
| The extension performs several validation checks: | ||
|
|
||
| * Verifies Floquet Ports are correctly defined | ||
| * Checks for lattice pair boundaries | ||
| * Validates design integrity | ||
| * Confirms angular sweep configuration | ||
| * Calculates total number of frequency points and spatial directions | ||
|
|
||
| Requirements | ||
| ------------ | ||
| **General:** | ||
|
|
||
| * Unit-cell HFSS design with Floquet ports defined | ||
| * Lattice pair boundaries configured | ||
|
|
||
| **Specific for the Extraction Workflow:** | ||
|
|
||
| * Design variables ``scan_T`` (theta) and ``scan_P`` (phi) assigned to Lattice Pairs | ||
| * Both spatial and frequency sampling distributions should be uniform | ||
|
|
||
| Command line usage | ||
| ------------------ | ||
|
|
||
| You can also launch the extension from the terminal: | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| from ansys.aedt.core.extensions.hfss.fresnel import FresnelExtension | ||
|
|
||
| extension = FresnelExtension(withdraw=False) | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 2 | ||
|
|
||
| ../commandline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.