Skip to content

doc: Include ruleset files in documentation #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 11, 2024
Merged

doc: Include ruleset files in documentation #528

merged 7 commits into from
Nov 11, 2024

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Nov 8, 2024 •
edited
Loading

Closes #527

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review November 8, 2024 09:33
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team November 8, 2024 09:37
SMoraisAnsys
SMoraisAnsys approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment

jorgepiloto
jorgepiloto reviewed Nov 8, 2024
View reviewed changes
jorgepiloto
jorgepiloto reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @AlejandroFernandezLuces. Just left a comment.

@AlejandroFernandezLuces AlejandroFernandezLuces enabled auto-merge (squash) November 11, 2024 08:53
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit dfebe88 into main Nov 11, 2024
11 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the doc/add-rulesets branch November 11, 2024 08:56
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
@AlejandroFernandezLuces @SMoraisAnsys
doc: Include ruleset files in documentation (#528)
06fcd1b 
* doc: Include ruleset files in documentation

* fix: small errors

* fix: Accept ruleset

* Update doc/styles/config/vocabularies/ANSYS/accept.txt

Co-authored-by: Sébastien Morais <[email protected]>

* fix: Remove references to repositories

---------

Co-authored-by: Sébastien Morais <[email protected]>
@greschd
Copy link
Member

greschd commented Nov 19, 2024

@AlejandroFernandezLuces having used this, I have two questions / comments:

  • shouldn't the "branch naming" protection apply to all branches, not just main?
  • it appears docs/ is missing in the list of allowed branch name patterns.

@AlejandroFernandezLuces
Copy link
Contributor Author

@AlejandroFernandezLuces having used this, I have two questions / comments:

  • shouldn't the "branch naming" protection apply to all branches, not just main?
  • it appears docs/ is missing in the list of allowed branch name patterns.

Agreed, thanks for raising those points. I'll make the fixes in a follow up PR.

@AlejandroFernandezLuces AlejandroFernandezLuces mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto left review comments

@RobPasMue RobPasMue RobPasMue left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new ruleset files with common rules.
5 participants
@AlejandroFernandezLuces @greschd @jorgepiloto @RobPasMue @SMoraisAnsys