Create a ResultInfo #1372
Merged
Create a ResultInfo #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1372 +/- ##
==========================================
+ Coverage 87.51% 87.58% +0.07%
==========================================
Files 81 81
Lines 9360 9387 +27
==========================================
+ Hits 8191 8222 +31
+ Misses 1169 1165 -4 |
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
Signed-off-by: paul.profizi <[email protected]>
cbellot000
reviewed
Jan 25, 2024
| This class describes the metadata of the analysis and the available results. | ||
| .. note:: | ||
| Creating a new ResultInfo from an analysis type and physics type is currently only available |
Contributor
There was a problem hiding this comment.
I see that you add more more capabilities available witha single server type, I'm afraid that it's going to make the library hard to use :/ (I found the issue with the streams class 2 days ago)
Contributor
There was a problem hiding this comment.
Are you following up to expand to other server types after?
Contributor
Author
There was a problem hiding this comment.
@cbellot000 definitely, yes. But this can be merged first to allow for a custom operator to create a ResultInfo.
Signed-off-by: paul.profizi <[email protected]>
cbellot000
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creation of a ResultInfo. Only available for InProcess for now.