-
Notifications
You must be signed in to change notification settings - Fork 23
Create a ResultInfo #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Create a ResultInfo #1372
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
25cb551
Allow creation of a new ResultInfo
PProfizi 0855806
Fix create new ResultInfo
PProfizi dd87269
Add ResultInfo.add_result
PProfizi fc74c41
Fix ResultInfo.add_result
PProfizi cb7e3c0
Add test create_result_info
PProfizi 411c5b3
Mark as unavailable via gRPC
PProfizi 4f128b9
Fix retro
PProfizi 71a2321
Fix retro
PProfizi e2d320b
Fix QA
PProfizi de08934
Fix retro
PProfizi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you add more more capabilities available witha single server type, I'm afraid that it's going to make the library hard to use :/ (I found the issue with the streams class 2 days ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you following up to expand to other server types after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 definitely, yes. But this can be merged first to allow for a custom operator to create a ResultInfo.