-
Notifications
You must be signed in to change notification settings - Fork 23
Feature: allow setting named dimensionless units in a Field #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… of unit setter to allow tuple as parameter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2295 +/- ##
==========================================
- Coverage 84.07% 84.04% -0.04%
==========================================
Files 91 91
Lines 10506 10514 +8
==========================================
+ Hits 8833 8836 +3
- Misses 1673 1678 +5 |
|
@anshlachamb Tests are failing because 26.1 server is not up-to-date. They should pass again after today's code update in about 5/6h |
|
@rafacanton for some strange reason this is failing only on Docker https://github.com/ansys/pydpf-core/actions/runs/15396696652/job/43319174056?pr=2295#step:17:2768 |
Following the addition of a new Unit ctor on server side, we propose to add the same option on client side:
Field.unit can now be set with a dimensionless (not homogeneous to anything) unit, with a custom name.
Usefull especially for pyAnsys Sound, where lots of "psychoacoustic" units are dimensionless and named.