-
Notifications
You must be signed in to change notification settings - Fork 23
Feature: allow setting named dimensionless units in a Field #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
53cf486
feat: allow giving a name to a dimensionless unit (eg: sones)
anshlachamb ea3a856
feat: remove set_named_dimensionless_unit. Replace it by an extension…
anshlachamb 7cb7a46
feat: use Homogeneity enum. Rework documentation
anshlachamb a2db93c
Merge branch 'master' into feat/named_dimensionless_units
rafacanton 96b1a9b
Merge branch 'master' into feat/named_dimensionless_units
PProfizi 7043f9c
Fix version criterion for test and feature
PProfizi cc25009
Raise for version too low
PProfizi 82f68ad
Fix QA
PProfizi d038ca2
Merge branch 'master' into feat/named_dimensionless_units
PProfizi 512f48b
Fix QA
PProfizi d1a2657
Use builtin ValueError
PProfizi 1f41c7d
Fix call to ValueError
PProfizi 2fdf822
Fix Style check
PProfizi e5719ac
Fix QA
PProfizi af643b2
Fix QA
PProfizi 334fe36
Merge branch 'master' into feat/named_dimensionless_units
PProfizi 03f370c
Merge branch 'master' into feat/named_dimensionless_units
anshlachamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.