Skip to content

refactor: extract color pair generation into helper function #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JvPaciello wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: extract color pair generation into helper function #4791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions scripts/preview-theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ import { isValidHexColor, isValidGradient } from "../src/common/color.js";
import { themes } from "../themes/index.js";
import { getGithubToken, getRepoInfo } from "./helpers.js";

const getColorPairs = (colors) => ({
title_color: [colors.title_color, colors.bg_color],
icon_color: [colors.icon_color, colors.bg_color],
text_color: [colors.text_color, colors.bg_color],
});

const COMMENTER = "github-actions[bot]";

const COMMENT_TITLE = "Automated Theme Preview";
Expand Down Expand Up @@ -541,11 +547,9 @@ export const run = async () => {
const bgColor = colors.bg_color;
const borderColor = colors.border_color;
const url = getGRSLink(colors);
const colorPairs = {
title_color: [titleColor, bgColor],
icon_color: [iconColor, bgColor],
text_color: [textColor, bgColor],
};

const colorPairs = getColorPairs(colors);

Object.keys(colorPairs).forEach((item) => {
let color1 = colorPairs[item][0];
let color2 = colorPairs[item][1];
Expand Down