Skip to content

Fix - Allow ExtendProgramChecked in CPI#6245

Merged
Lichtso merged 2 commits intoanza-xyz:masterfrom
Lichtso:fix/extend_program_checked
May 15, 2025
Merged

Fix - Allow ExtendProgramChecked in CPI#6245
Lichtso merged 2 commits intoanza-xyz:masterfrom
Lichtso:fix/extend_program_checked

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented May 14, 2025

Problem

See solana-foundation/solana-improvement-documents#164 (comment).

Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/87

Summary of Changes

Allows invoking loader-v3 ExtendProgramChecked in CPI.
Rekeys the feature enable_extend_program_checked.

@Lichtso Lichtso requested a review from a team as a code owner May 14, 2025 14:16
@mergify
Copy link
Copy Markdown

mergify bot commented May 14, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the fix/extend_program_checked branch from a751fc3 to 67a9cf3 Compare May 14, 2025 14:25
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.7%. Comparing base (b56095d) to head (67a9cf3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6245   +/-   ##
=======================================
  Coverage    82.7%    82.7%           
=======================================
  Files         843      843           
  Lines      377600   377606    +6     
=======================================
+ Hits       312608   312622   +14     
+ Misses      64992    64984    -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lichtso Lichtso merged commit f5616d3 into anza-xyz:master May 15, 2025
58 checks passed
@Lichtso Lichtso deleted the fix/extend_program_checked branch May 15, 2025 14:14
Lichtso added a commit that referenced this pull request May 15, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.
Lichtso added a commit that referenced this pull request May 16, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.
Lichtso added a commit that referenced this pull request Jun 4, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.
@Lichtso Lichtso added the v2.2 label Jun 6, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Jun 6, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jun 6, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)

# Conflicts:
#	Cargo.lock
#	programs/sbf/Cargo.lock
#	svm/examples/Cargo.lock
Lichtso added a commit that referenced this pull request Jun 6, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)
Lichtso added a commit that referenced this pull request Jun 6, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)
t-nelson pushed a commit that referenced this pull request Jun 10, 2025
* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)
Lichtso added a commit that referenced this pull request Jun 11, 2025
)

Fix - Allow ExtendProgramChecked in CPI (#6245)

* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants