Fix: Handle None values in has_fa_suffix() for pretrained classifiers#184
Open
clementcoclet wants to merge 1 commit intoV2from
Open
Fix: Handle None values in has_fa_suffix() for pretrained classifiers#184clementcoclet wants to merge 1 commit intoV2from
clementcoclet wants to merge 1 commit intoV2from
Conversation
- Add check for None and empty string values before calling endswith() - Prevents AttributeError when refseqs_file/taxa_file are None for pretrained classifiers - Fixes issue where naive-bayes with pretrained_classifier fails when refseqs_file is null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an
AttributeErrorthat occurs when using a pretrained classifier with thenaive-bayesclassification method. Thehas_fa_suffix()function was being called onNonevalues forrefseqs_fileandtaxa_file, which are correctly set tonullwhen using a pretrained classifier.Changes
has_fa_suffix()function to check forNoneand empty string values before calling.endswith()FalseforNoneor empty values, allowing theif/elifchain to proceed correctlyError Fixed