fix: missing trusted_addresses #900
Conversation
https://github.com/apache/apisix/pull/12551/files. The breaking change is introduced here, but it's not addressed in the helm chart
|
Waiting for approval on this PR too! |
bzp2010
left a comment
bzp2010
left a comment
There was a problem hiding this comment.
The version in Chart.yaml should also be updated for automated release.
| {{- end }} | ||
| trusted_addresses: {{ toYaml .Values.apisix.trusted_addresses | nindent 8 }} |
There was a problem hiding this comment.
Please ensure that this can be applied to a YAML list including multiple CIDRs.
There was a problem hiding this comment.
If no activity today I'll update with the changes
There was a problem hiding this comment.
Don't forget to add an empty default value and some description/documentation in the values.yaml file.
Also, try to follow Helm naming conventions for values (camelCase instead of snake_case): change it to trustedAddresses
There was a problem hiding this comment.
Hey folks, apologies for the delay, I can address the changes in few hours
There was a problem hiding this comment.
Right then, we now have two related PRs. 😆
There was a problem hiding this comment.
😄 let's just merge the one which is ready then
4 participants
https://github.com/apache/apisix/pull/12551/files. The breaking change is introduced here, but it's not addressed in the helm chart