Skip to content

fix: missing trusted_addresses #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aliibii wants to merge 1 commit into from
Closed

fix: missing trusted_addresses #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/apisix/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ data:
{{- if or .Values.apisix.customPlugins.enabled .Values.apisix.luaModuleHook.enabled }}
extra_lua_path: {{ .Values.apisix.customPlugins.luaPath }};{{ .Values.apisix.luaModuleHook.luaPath }}
{{- end }}


trusted_addresses: {{ toYaml .Values.apisix.trusted_addresses | nindent 8 }}
Copy link
Contributor

@bzp2010 bzp2010 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that this can be applied to a YAML list including multiple CIDRs.

Copy link
Contributor

@manueljishi manueljishi Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no activity today I'll update with the changes

Copy link

@ngclinflows ngclinflows Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add an empty default value and some description/documentation in the values.yaml file.

Also, try to follow Helm naming conventions for values (camelCase instead of snake_case): change it to trustedAddresses

Copy link
Author

@aliibii aliibii Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks, apologies for the delay, I can address the changes in few hours

Copy link
Contributor

@bzp2010 bzp2010 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right then, we now have two related PRs. 😆

Copy link
Author

@aliibii aliibii Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 let's just merge the one which is ready then


enable_control: {{ .Values.control.enabled }}
{{- if .Values.control.enabled }}
control:
Expand Down