feat: support custom metrics #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 250 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 177 | 1 | 72 | 0 |
Click to see the invalid file list
- test/e2e/load-test/spec_subject.go
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
AlinsRan
reviewed
Jul 18, 2025
internal/provider/adc/adc.go
Outdated
|
|
||
| err := d.executor.Execute(ctx, d.BackendMode, config, args) | ||
| duration := time.Since(startTime).Seconds() | ||
| log.Infof("synced %s in %f seconds, service list length: %d", config.Name, duration, len(task.Resources.Services)) |
Contributor
There was a problem hiding this comment.
The service in the info log here is ambiguous.
The user does not understand whether it is a k8s service or something else.
Contributor
Author
There was a problem hiding this comment.
i will remove it later.
AlinsRan
approved these changes
Jul 18, 2025
Signed-off-by: ashing <[email protected]>
nic-6443
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Exposing some key metrics can enable us to understand the time consumption of different steps, thereby better locating the problem.
Pre-submission checklist: