fix: pin test-nginx to a working version to fix tests with --- http2 #11816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Revolyssup
changed the title
moonming
approved these changes
Dec 10, 2024
membphis
approved these changes
Dec 10, 2024
shreemaan-abhishek
approved these changes
Dec 10, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
The latest version of test-nginx is not compatible with the current set of tests with ---http2
due to this commit: openresty/test-nginx@0ccd106
This change pins test-nginx to a commit before this one.
Here is the example of failing CI: https://github.com/apache/apisix/actions/runs/12135444416/job/34116587041?pr=11793#step:19:224
Other example of failing CI https://github.com/apache/apisix/actions/runs/11968599308/job/34140905040?pr=11765
Checklist