Skip to content

fix: add support for ignoring "load" global variable #11862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Revolyssup merged 3 commits into from
Dec 30, 2024
Merged

fix: add support for ignoring "load" global variable #11862

Revolyssup merged 3 commits into from
Dec 30, 2024

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Dec 25, 2024 •
edited
Loading

Description

Fixes # (issue)
lua global load is not covered by default by the lj-relang which is used for lint tests. This PR makes sure overrides the code with the one which takes that into account
needed for this: #11793

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Dec 25, 2024
Revolyssup
Revolyssup commented Dec 25, 2024
View reviewed changes
utils/lj-releng
|os|print|tonumber|math|pcall|xpcall|unpack
|pairs|ipairs|assert|module|package
|coroutine|[gs]etfenv|next|rawget|rawset
|loadstring|dofile|collectgarbage|load
Copy link
Contributor Author

@Revolyssup Revolyssup Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load is added here

@Revolyssup Revolyssup mentioned this pull request Dec 25, 2024
Merged
5 tasks
membphis
membphis reviewed Dec 30, 2024
View reviewed changes
@Revolyssup Revolyssup requested a review from nic-6443 December 30, 2024 12:48
@Revolyssup Revolyssup merged commit b89c1a0 into apache:master Dec 30, 2024
33 checks passed
@Revolyssup Revolyssup deleted the revolyssup/fix-lint branch December 30, 2024 13:42
@LiteSun LiteSun mentioned this pull request Jun 10, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

Assignees

No one assigned

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revolyssup @membphis @nic-6443 @shreemaan-abhishek