build(c): work around clang making __COUNTER__ a warning#4044
Open
lidavidm wants to merge 1 commit intoapache:mainfrom
Open
build(c): work around clang making __COUNTER__ a warning#4044lidavidm wants to merge 1 commit intoapache:mainfrom
__COUNTER__ a warning#4044lidavidm wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
CC @paleolimbot this happens on recent Clang: google/benchmark#2057 I did the hacky thing to get around it but maybe it would be better to fix this in nanoarrow. |
paleolimbot
reviewed
Mar 5, 2026
Member
paleolimbot
left a comment
There was a problem hiding this comment.
Can you wrap auto&& NAME = (RHS) in a scope in the _IMPL macros?
do {
auto&& NAME = (RHS);
if (!(NAME).ok()) {
return (NAME).ToADBC(ERROR);
}
} while(0);...should be safe, although won't work for UNWRAP_RESULT(some_type some_var) unless this works:
lhs;
do {
auto&& NAME = (RHS);
if (!(NAME).has_value()) {
return std::move(name).status();
}
lhs = std::move((name).value());
} while(0);In nanoarrow I think I can just define the status name to be a hard-coded long but almost certainly unique value since all return values would happen via side-effect and not the result code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4042.