Skip to content

ci(rust): suppress unused features error for unstable non_exhaustive_omitted_patterns_lint only used in arrow_ffi #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 5 commits into from
Mar 8, 2026
+7 −1
Merged

ci(rust): suppress unused features error for unstable non_exhaustive_omitted_patterns_lint only used in arrow_ffi #4055

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db1141
ci(rust): remove unused flag for nightly clippy
eitsupi Mar 7, 2026
fadad44
ci(rust): ensure enable the flag for adbc_ffi
eitsupi Mar 7, 2026
66d1a7f
ci(rust): suppress unused_features error for non_exhaustive_omitted_p…
eitsupi Mar 7, 2026
bd23ca1
chore: test `non_exhaustive_omitted_patterns` works
eitsupi Mar 7, 2026
10e6189
Revert "chore: test `non_exhaustive_omitted_patterns` works"
eitsupi Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,13 @@ jobs:
working-directory: rust
run: |
rustup toolchain install nightly --component clippy
cargo +nightly clippy --workspace --all-targets --all-features --locked -- -Dwarnings -Zcrate-attr='feature(non_exhaustive_omitted_patterns_lint)'
# -Zcrate-attr enables the unstable non_exhaustive_omitted_patterns lint
# (https://github.com/apache/arrow-adbc/pull/3245).
# It applies to all workspace packages, so we also allow unused_features for crates that
# don't use the lint.
cargo +nightly clippy --workspace --all-targets --all-features --locked -- -Dwarnings \
-Zcrate-attr='feature(non_exhaustive_omitted_patterns_lint)' \
-Zcrate-attr='allow(unused_features)'
- name: Test (Default Features)
working-directory: rust
# TODO: enable snowflake tests on windows
Expand Down
Loading