GH-45559: [C#] Increasing performance by avoiding array allocation everytime method gets used #45609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Have you benchmarked to confirm whether this change makes any performance difference? It's my understanding -- backed up by an experiment with SharpLab -- that the C# compiler translates the idiom static ReadOnlySpan<byte> Property => new byte[] { ... }; into a reference directly into static data. (The C# compiler PR in question is dotnet/roslyn#24621.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Improve the performance of the GetBit operations by avoiding array allocation everytime method get used.
What changes are included in this PR?
Small changes to the class where the PopcountTable and BitMask both become static readonly byte-arrays.
Are these changes tested?
Yes, all changes pass
Are there any user-facing changes?
No breaking changes.