Skip to content

GH-47370: [Python] Require Cython 3.1#47396

Merged
AlenkaF merged 1 commit intoapache:mainfrom
thisisnic:GH-47370_cython3.1
Sep 2, 2025
Merged

GH-47370: [Python] Require Cython 3.1#47396
AlenkaF merged 1 commit intoapache:mainfrom
thisisnic:GH-47370_cython3.1

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Aug 21, 2025

Rationale for this change

Upgrading Cython to version 3.1

What changes are included in this PR?

Replace all mentions of earlier versions with 3.1

Are these changes tested?

Nah but I'll run CI

Are there any user-facing changes?

Only if they're using Cython < 3.1

@thisisnic
Copy link
Member Author

@github-actions crossbow submit -g python

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 21, 2025
@github-actions
Copy link

Revision: bdded002dc1c13c2939f46b12f59cd5f30ce86cd

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f0c2ad351

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-42-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@kou kou changed the title GH-47370: [Python] Require Cython 3.1 GH-47370: [Python] Require Cython 3.1 Aug 22, 2025
@raulcd
Copy link
Member

raulcd commented Aug 27, 2025

The macOS failures have been fixed on main, could you rebase to validate CI?

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good to me.

The two MinGW failures are not connected and are tracked here:
#47440

Will wait for one last check from @raulcd before we merge.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I've compared with the changes we did when we updated to minimum required Cython 3 and it seems like everything is covered:

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Sep 1, 2025
@raulcd
Copy link
Member

raulcd commented Sep 1, 2025

I plan to merge this as we all seem to be on agreement, I'll merge in the next couple of days unless there's any concern.
@WillAyd @pitrou FYI

@pitrou
Copy link
Member

pitrou commented Sep 1, 2025

As a followup task, perhaps look for places in the codebase where we can simplify things?

@WillAyd
Copy link
Contributor

WillAyd commented Sep 1, 2025

Thanks!

@thisisnic
Copy link
Member Author

As a followup task, perhaps look for places in the codebase where we can simplify things?

Sounds good, is there any particular kind of thing we want to simplify?

@pitrou
Copy link
Member

pitrou commented Sep 1, 2025

You'll find at least some ideas in the original issue ;)

@AlenkaF
Copy link
Member

AlenkaF commented Sep 2, 2025

Thank you @thisisnic!
I have created a follow-up issue (#47467) and will go ahead and merge the changes here.

@AlenkaF AlenkaF merged commit 940592b into apache:main Sep 2, 2025
27 of 29 checks passed
@AlenkaF AlenkaF removed the awaiting merge Awaiting merge label Sep 2, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 940592b.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants