GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0#48377
GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0#48377kou merged 1 commit intoapache:mainfrom
Conversation
This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros. Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc. See: google/googletest@59c924b
|
|
|
|
|
Thanks for this! @kou what do you think? |
|
@github-actions crossbow submit -g cpp |
|
Revision: e60782e Submitted crossbow builds: ursacomputing/crossbow @ actions-31a1fe2b5e |
|
|
1 similar comment
|
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 09f1561. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in
ASSERT_DOUBLE_EQandASSERT_FLOAT_EQmacros.Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written).
See: google/googletest@59c924b
What changes are included in this PR?
Updated
cpp/thirdparty/versions.txt:ARROW_GTEST_BUILD_VERSION: 1.16.0 -> 1.17.0ARROW_GTEST_BUILD_SHA256_CHECKSUM: Updated to match new versionAre these changes tested?
This is a dependency version update. Existing tests will validate compatibility.
Are there any user-facing changes?
No. This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros.
Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc.
See: google/googletest@59c924b