Skip to content

GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0#48377

Merged
kou merged 1 commit intoapache:mainfrom
tennisleng:update-gtest-1.17
Dec 11, 2025
Merged

GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0#48377
kou merged 1 commit intoapache:mainfrom
tennisleng:update-gtest-1.17

Conversation

@tennisleng
Copy link
Copy Markdown
Contributor

@tennisleng tennisleng commented Dec 6, 2025

Rationale for this change

This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros.

Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written).

See: google/googletest@59c924b

What changes are included in this PR?

Updated cpp/thirdparty/versions.txt:

  • ARROW_GTEST_BUILD_VERSION: 1.16.0 -> 1.17.0
  • ARROW_GTEST_BUILD_SHA256_CHECKSUM: Updated to match new version

Are these changes tested?

This is a dependency version update. Existing tests will validate compatibility.

Are there any user-facing changes?

No. This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros.

Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc.

See: google/googletest@59c924b

This updates GoogleTest to version 1.17.0 to prevent potential undefined
behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros.

Prior to version 1.17, GoogleTest used union-based type punning which is
undefined behavior in C++ (reading from a union member that wasn't most
recently written). This was fixed in GoogleTest commit 59c924bc.

See: google/googletest@59c924b
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2025

⚠️ GitHub issue #48376 has been automatically assigned in GitHub to PR creator.

@tennisleng tennisleng changed the title GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 Dec 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2025

⚠️ GitHub issue #48376 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zanmato1984
Copy link
Copy Markdown
Contributor

Thanks for this!

@kou what do you think?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 11, 2025
@zanmato1984
Copy link
Copy Markdown
Contributor

@github-actions crossbow submit -g cpp

@github-actions
Copy link
Copy Markdown

Revision: e60782e

Submitted crossbow builds: ursacomputing/crossbow @ actions-31a1fe2b5e

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #48376 has been automatically assigned in GitHub to PR creator.

1 similar comment
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #48376 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 09f1561 into apache:main Dec 11, 2025
44 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Dec 11, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 09f1561.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants