Skip to content

GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop#48392

Merged
kou merged 1 commit intoapache:mainfrom
hiroyuki-sato:topic/ruby-trailing-empty-lines
Dec 8, 2025
Merged

GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop#48392
kou merged 1 commit intoapache:mainfrom
hiroyuki-sato:topic/ruby-trailing-empty-lines

Conversation

@hiroyuki-sato
Copy link
Copy Markdown
Collaborator

@hiroyuki-sato hiroyuki-sato commented Dec 8, 2025

Rationale for this change

This fix introduces new Ruby formatting checks to streamline multi-person development.

What changes are included in this PR?

Enable Layout/TrailingEmptyLines options

# `final_newline` looks for one newline at the end of files.

# bad
class Foo; end

# EOF

# bad
class Foo; end # EOF

# good
class Foo; end
# EOF

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@hiroyuki-sato hiroyuki-sato requested a review from kou as a code owner December 8, 2025 01:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

⚠️ GitHub issue #48386 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit ba27b8f into apache:main Dec 8, 2025
13 checks passed
@kou kou removed the awaiting review Awaiting review label Dec 8, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 8, 2025
@hiroyuki-sato hiroyuki-sato deleted the topic/ruby-trailing-empty-lines branch December 8, 2025 04:33
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ba27b8f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants