Skip to content

GH-47800: [C++][CI] Fuzz more CSV reader types#48398

Merged
pitrou merged 1 commit intoapache:mainfrom
pitrou:gh47800-fuzz-more-csv-readers
Dec 8, 2025
Merged

GH-47800: [C++][CI] Fuzz more CSV reader types#48398
pitrou merged 1 commit intoapache:mainfrom
pitrou:gh47800-fuzz-more-csv-readers

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Dec 8, 2025

Rationale for this change

The CSV fuzz target was fuzz-testing only the threaded table reader. This PR adds fuzz testing for more CSV-reading code paths:

  • the serial table reader
  • the streaming reader
  • the row-counting reader, with both possible chunker implementations depending on whether newlines are allowed in CSV values

Are these changes tested?

Manually.

Are there any user-facing changes?

No.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

⚠️ GitHub issue #47800 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 8, 2025

@github-actions crossbow submit fuzz

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 8, 2025

@kou @WillAyd Would you perhaps like to review this?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

Revision: c4097a9

Submitted crossbow builds: ursacomputing/crossbow @ actions-e472945c83

Task Status
test-build-cpp-fuzz GitHub Actions

Copy link
Copy Markdown
Contributor

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 8, 2025
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 8, 2025

Thanks for the review @WillAyd !

@pitrou pitrou merged commit af4f895 into apache:main Dec 8, 2025
45 of 46 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Dec 8, 2025
@pitrou pitrou deleted the gh47800-fuzz-more-csv-readers branch December 8, 2025 16:04
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit af4f895.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants