Skip to content

GH-48410: [Ruby] Add support for reading large list array#48411

Merged
kou merged 1 commit intoapache:mainfrom
kou:ruby-large-list-array
Dec 9, 2025
Merged

GH-48410: [Ruby] Add support for reading large list array#48411
kou merged 1 commit intoapache:mainfrom
kou:ruby-large-list-array

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Dec 9, 2025

Rationale for this change

It's a large variant of list array.

What changes are included in this PR?

  • Add ArrowFormat::LargeListType
  • Add ArrowFormat::LargeListArray
  • Improve large list support in Red Arrow

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

⚠️ GitHub issue #48410 has been automatically assigned in GitHub to PR creator.

@hiroyuki-sato hiroyuki-sato self-requested a review December 9, 2025 10:50
Copy link
Copy Markdown
Collaborator

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

./test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:61: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.185235711 seconds.
--------------------------------------------------------------------------------
12 tests, 12 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------
64.78 tests/s, 64.78 assertions/s

@kou kou merged commit 1515197 into apache:main Dec 9, 2025
10 checks passed
@kou kou deleted the ruby-large-list-array branch December 9, 2025 21:27
@kou kou removed the awaiting committer review Awaiting committer review label Dec 9, 2025
@kou
Copy link
Copy Markdown
Member Author

kou commented Dec 10, 2025

@github-actions crossbow submit test-debian-ruby

@github-actions
Copy link
Copy Markdown

Revision: 2fd3588

Submitted crossbow builds: ursacomputing/crossbow @ actions-5c5c0f4646

Task Status
test-debian-ruby GitHub Actions

kou added a commit to kou/arrow that referenced this pull request Dec 11, 2025
kou added a commit that referenced this pull request Dec 11, 2025
### Rationale for this change

They should have been included in #48411.

### What changes are included in this PR?

Add missing tests.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #48437

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1515197.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants